flake8
passed.
JSHint
passed.
Add manual trigger run and retry for JenkinsCI integration.
Review Request #11225 — Created Oct. 15, 2020 and submitted
Add manual trigger to JenkinsCI.
This change adds the ability for Integrations to run JenkinsCI manually.
A checkbox is added to the JenkinsCI form that indicates if JenkinsCI should
only run manually.The password form label has also been updated to emphasize using an API token
instead of the user's password since newer versions of Jenkins only works with
API tokens.This change also fixes the Jenkins API failing for Review Board 3 because
request.open()was not valid.Based on work by David Trowbridge: /r/11130
Manually tested on Review Board 3. Jenkins was set up with Docker and
connected to a GitHub repository and Review Board 3. A Jenkins build was
not run when the manually run checkbox is unchecked and is run when the
field is checked. Clicking on the 'Run' button runs the Jenkins build.Verified the disabled/enabled run manually field by testing on Review Board
3.0.18, 3.0.19 and 4.0.x.Verified retry functionality when state is in ERROR and TIMEOUT states.
Unit tests to verify that a build is not run when the manually run
configuration is checked and to verify that a build is run when the signal is
emitted.
| Summary | ID |
|---|---|
| f75508d87da09be7c63c48fc5a9237da0a77afd0 |
| Description | From | Last Updated |
|---|---|---|
|
F401 'importlib' imported but unused |
 reviewbot
|
- Change Summary:
-
Finalize WIP
- Summary:
-
[WIP] Add manual trigger to JenkinsCI.Add manual trigger to JenkinsCI integration.
- Description:
-
Add manual trigger to JenkinsCI.
This change adds the ability for Integrations to run JenkinsCI manually.
~ A checkbox is added to the JenkinsCI form that indicates if JenkinsCI should only ~ run manually. ~ A checkbox is added to the JenkinsCI form that indicates if JenkinsCI should ~ only run manually. The password form label has also been updated to emphasize using an API token
instead of the user's password since newer versions of Jenkins only works with API tokens. + This change also fixes the Jenkins API failing for Review Board 3 because
+ request.open()was not valid.+ Based on work by David Trowbridge: /r/11130
- Testing Done:
-
~ Tested on Review Board 3. More to come.
~ Manually tested on Review Board 3. Jenkins was set up with Docker and
+ connected to a GitHub repository and Review Board 3. A Jenkins build was + not run when the manually run checkbox is unchecked and is run when the + field is checked. Clicking on the 'Run' button runs the Jenkins build. + + Unit tests to verify that a build is not run when a the manually run
+ configuration is checked and to verify that a build is run when the signal is + emitted. - Commits:
-
Summary ID 5a10268a2465ee296e7a6d05cd84f80b8f1cfcd2 04a981044b87c55d103365c8488d4de3dcda61a2 07cca4ef6e30ff58527c6260068784ec7aec3133 248fbed5cde7e49cd691b4313f1754774e8edd7d
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Testing Done:
-
Manually tested on Review Board 3. Jenkins was set up with Docker and
connected to a GitHub repository and Review Board 3. A Jenkins build was not run when the manually run checkbox is unchecked and is run when the field is checked. Clicking on the 'Run' button runs the Jenkins build. ~ Unit tests to verify that a build is not run when a the manually run
~ Unit tests to verify that a build is not run when the manually run
configuration is checked and to verify that a build is run when the signal is emitted.
- Change Summary:
-
Minor documentation fixup
- Commits:
-
Summary ID 04a981044b87c55d103365c8488d4de3dcda61a2 07cca4ef6e30ff58527c6260068784ec7aec3133 248fbed5cde7e49cd691b4313f1754774e8edd7d 4f06f637211c2754cf3ecef170656aacb04855b0 c7ddc6359c1483ba1c0ef0d211f845eff87a5d1e 845384c8dae1631f08cd1607f82f5310456d8a4a
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Disable run manually field on older versions of Review Board
- Commits:
-
Summary ID 4f06f637211c2754cf3ecef170656aacb04855b0 c7ddc6359c1483ba1c0ef0d211f845eff87a5d1e 845384c8dae1631f08cd1607f82f5310456d8a4a ec42303dfa9e5ee71d65d7ebc775c4118d317855
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Testing Done:
-
Manually tested on Review Board 3. Jenkins was set up with Docker and
connected to a GitHub repository and Review Board 3. A Jenkins build was not run when the manually run checkbox is unchecked and is run when the field is checked. Clicking on the 'Run' button runs the Jenkins build. + Tested on Review Board 3.0.19, 3.0.18 and 4.0.x to verify the disabled
+ run manually field. + Unit tests to verify that a build is not run when the manually run
configuration is checked and to verify that a build is run when the signal is emitted.
- Testing Done:
-
Manually tested on Review Board 3. Jenkins was set up with Docker and
connected to a GitHub repository and Review Board 3. A Jenkins build was not run when the manually run checkbox is unchecked and is run when the field is checked. Clicking on the 'Run' button runs the Jenkins build. ~ Tested on Review Board 3.0.19, 3.0.18 and 4.0.x to verify the disabled
~ run manually field. ~ Verified the disabled/enable run manually field by testing on Review Board
~ 3.0.18, 3.0.19 and 4.0.x. Unit tests to verify that a build is not run when the manually run
configuration is checked and to verify that a build is run when the signal is emitted.
- Testing Done:
-
Manually tested on Review Board 3. Jenkins was set up with Docker and
connected to a GitHub repository and Review Board 3. A Jenkins build was not run when the manually run checkbox is unchecked and is run when the field is checked. Clicking on the 'Run' button runs the Jenkins build. ~ Verified the disabled/enable run manually field by testing on Review Board
~ Verified the disabled/enabled run manually field by testing on Review Board
3.0.18, 3.0.19 and 4.0.x. Unit tests to verify that a build is not run when the manually run
configuration is checked and to verify that a build is run when the signal is emitted.
- Change Summary:
-
Fix typo in can_retry extra_data
- Commits:
-
Summary ID ec42303dfa9e5ee71d65d7ebc775c4118d317855 658afa3d85686f281623e3681614c074dc8d06e2
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Testing Done:
-
Manually tested on Review Board 3. Jenkins was set up with Docker and
connected to a GitHub repository and Review Board 3. A Jenkins build was not run when the manually run checkbox is unchecked and is run when the field is checked. Clicking on the 'Run' button runs the Jenkins build. Verified the disabled/enabled run manually field by testing on Review Board
3.0.18, 3.0.19 and 4.0.x. + Verified retry functionality when state is in ERROR and TIMEOUT states.
+ Unit tests to verify that a build is not run when the manually run
configuration is checked and to verify that a build is run when the signal is emitted.
- Change Summary:
-
Update based on comments on CircleCI patch
- Commits:
-
Summary ID 658afa3d85686f281623e3681614c074dc8d06e2 5636794d1dd582e5e815adb07ed0b022c8777cac
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
