Add the ability to toggle display of entire files.

 






 

 


  Review Request #11210
  —
  Created Oct. 5, 2020 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  keanweng
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard, students
 









 
 

  
 






 








 





  


 
 

  
The current diff viewer shows the changes for all files and it can be 

tedious to scroll through, especially with large changes. Adding the 

ability to hide/unhide files will better allow users to look at only 

a subset of the changes at once.


We added a toggle to the header for each file that collapses the file 

to a single line filename. Toggling a collapsed file header will expand 

the entire file. This feature is referenced from the toggling of 

Reviews in a Review Request. When the toggle button is clicked, 

jQuery toggle() is called on the revision-row class and tbody 

attribute. The toggle() function works toggling the CSS display 

property between display: none.

 








  


 
 

  
Wrote onToggleCollapseClicked in diffReviewableViewTests.es6.js.

 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3
4
5
6
7

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    
Add toggle button and function for diff files.

   
  		
  fbeec8382b711654a5822e852463d2ded66be71e
  Kean Weng Yap
 


 
  
 
 
  
   
    
Add JS test for expand toggle diff files.

   
  		
  763b8a0adde47974a200732bbd1de610abe449c8
  Kean Weng Yap
 


 
  
 
 
  
   
    

     The current diff viewer shows the changes for all files and it can be
     
tedious to scroll through, especially with large changes. Adding the
ability to hide/unhide files will better allow users to look at only
a subset of the changes at once.

We added a toggle to the header for each file that collapses the file
to a single line filename. Toggling a collapsed file header will expand
the entire file. This feature is referenced from the toggling of
`Reviews` in a `Review Request`. When the toggle button is clicked,
jQuery `toggle()` is called on the `revision-row` class and `tbody`
attribute. The `toggle()` function works toggling the CSS `display`
property between `display: none`.

Testing done:
Wrote `onToggleCollapseClicked` in `diffReviewableViewTests.es6.js`.

    

   
  		
  6f5e66f4461b400bd082cf8fab5592673398e5fd
  Kean Weng Yap
 




    


    


      
Files


      

    

    

   

  

 
















     

    

   

  

  

   
   Loading...