Add a Credential Checker tool for Review Bot

 






 

 


  Review Request #11206
  —
  Created Sept. 27, 2020 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  ceciliawei
 









 
 

  ReviewBot
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewbot, students
 









 
 

  jace, jblazusi
 






 








 





  


 
 

  
This change adds a tool for Review Bot to check for hard-coded security

credentials. I used regex to search on the patterns of the known

credential types. The result may include false positives.

 








  


 
 

  
Verified the functionality by installing the tool and manual

testing.

 







 









 





  








 




 







   

    
    
Changes between revision 4 and 5



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Add a Credential Checker tool for Review Bot
     
This change adds a tool for Review Bot to detect if a secret/credential
is included in the commit. I used regex to search on the patterns of the
known credential types. The result may include false positive.

Testing Done:
Verified the functionality by installing the integration and manual
testing.

Reviewed at https://reviews.reviewboard.org/r/11206/

    

   
  		
  b970b67ac8164a4d56aa4773d503162d184dd5fe
  ceciliaccwei
 


 
  
 
 
  
   
    

     Add a Credential Checker tool for Review Bot
     
This change adds a tool for Review Bot to detect if a secret/credential
is included in the commit. I used regex to search on the patterns of the
known credential types. The result may include false positive.

Testing Done:
Verified the functionality by installing the integration and manual
testing.

Reviewed at https://reviews.reviewboard.org/r/11206/

    

   
  		
  cd5abaa19b36743f07e76f5f563ba1135b3c6d39
  ceciliaccwei
 




    


    
    

   

  

 









 

  

   
    

     
      
      bot/reviewbot/tools/rbcredentialchecker.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...