Added check for return code when checking for bzr.

 






 

 


  Review Request #11196
  —
  Created Sept. 21, 2020 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  ruonanjia
 









 
 

  RBTools
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools, students
 









 
 

  
 






 








 





  


 
 

  
When pyenv is in use and the needed executable is only available in a 

different Python version, pyenv intercepts the call and will print 

an error/return 127.


When running bzr help under these conditions, we see this:

pyenv: bzr: command not found


The `bzr' command exists in these Python versions:

  2.7.14

 








  


 
 

  
Tested 'rbt post' manually in my local integrations repo with the changes.

 







 









 





  








 




 







   

    
    
Diff Revision 7


This is not the most recent revision of the diff. The latest diff is revision 8. See what's changed.

    

 

 

 

 
orig
1
2
3
4
5
6
7
8

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    
added check for return code and stderr when running bzr help

   
  		
  419d1a61a4634080d28b1e5b3676098866584505
  ruonan
 


 
  
   
  
  
   
  
 
 
  
   
    
Added check for return code and stderr when running bzr help

   
  		
  cd3f516d5bfbc81933ec5a26ce2b6529a76a71ac
  ruonan
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/utils/checks.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...