Add Matrix option to Integration
Review Request #11195 — Created Sept. 21, 2020 and discarded
Admins can choose to add Matrix Integration. This will send notifications to the registered matrix room about new review requets and updates to existing ones.
Tested in RB4.
Edited Slack unit test cases to test Matrix integration. All tests have passed except 2 of then complaining about missing image attachment
tests with errors are:
- test_notify_new_review_request_with_image_file_attachment
- test_notify_updated_review_request_with_new_image_attachments
Summary | ID | Author |
---|---|---|
62db098bbb68cc97cee8d5e2890c6108e018ab6b | ruonan |
Description | From | Last Updated |
---|---|---|
F401 'json' imported but unused |
reviewbot | |
F401 'django.utils.six.moves.urllib.request.Request' imported but unused |
reviewbot | |
F401 'django.utils.six.moves.urllib.request.urlopen' imported but unused |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
E303 too many blank lines (3) |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E303 too many blank lines (2) |
reviewbot | |
F401 'django.utils.six.moves.urllib.request.Request' imported but unused |
reviewbot | |
F401 'django.utils.six.moves.urllib.request.urlopen' imported but unused |
reviewbot | |
F841 local variable 'response' is assigned to but never used |
reviewbot | |
E302 expected 2 blank lines, found 1 |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
E501 line too long (86 > 79 characters) |
reviewbot | |
E501 line too long (94 > 79 characters) |
reviewbot | |
E501 line too long (82 > 79 characters) |
reviewbot | |
E501 line too long (89 > 79 characters) |
reviewbot | |
F401 'matrix_client.api.MatrixHttpApi' imported but unused |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E501 line too long (108 > 79 characters) |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E501 line too long (121 > 79 characters) |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E302 expected 2 blank lines, found 1 |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (103 > 79 characters) |
reviewbot | |
E501 line too long (118 > 79 characters) |
reviewbot | |
F821 undefined name 'self' |
reviewbot | |
E126 continuation line over-indented for hanging indent |
reviewbot | |
F821 undefined name 'json' |
reviewbot | |
F821 undefined name 'urlopen' |
reviewbot | |
E501 line too long (83 > 79 characters) |
reviewbot | |
E501 line too long (112 > 79 characters) |
reviewbot | |
E501 line too long (113 > 79 characters) |
reviewbot | |
E501 line too long (106 > 79 characters) |
reviewbot | |
E501 line too long (89 > 79 characters) |
reviewbot | |
E501 line too long (83 > 79 characters) |
reviewbot | |
E501 line too long (120 > 79 characters) |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E501 line too long (121 > 79 characters) |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E501 line too long (83 > 79 characters) |
reviewbot | |
E501 line too long (112 > 79 characters) |
reviewbot | |
E501 line too long (113 > 79 characters) |
reviewbot | |
E501 line too long (106 > 79 characters) |
reviewbot | |
E501 line too long (89 > 79 characters) |
reviewbot | |
W291 trailing whitespace |
reviewbot | |
E501 line too long (118 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (103 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (99 > 79 characters) |
reviewbot | |
E501 line too long (105 > 79 characters) |
reviewbot | |
E501 line too long (118 > 79 characters) |
reviewbot | |
E501 line too long (109 > 79 characters) |
reviewbot | |
E501 line too long (108 > 79 characters) |
reviewbot | |
E501 line too long (83 > 79 characters) |
reviewbot | |
E501 line too long (120 > 79 characters) |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E501 line too long (121 > 79 characters) |
reviewbot | |
E226 missing whitespace around arithmetic operator |
reviewbot | |
E501 line too long (83 > 79 characters) |
reviewbot | |
E501 line too long (112 > 79 characters) |
reviewbot | |
E501 line too long (113 > 79 characters) |
reviewbot | |
E501 line too long (106 > 79 characters) |
reviewbot | |
E501 line too long (89 > 79 characters) |
reviewbot | |
W291 trailing whitespace |
reviewbot | |
E501 line too long (118 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (103 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E501 line too long (99 > 79 characters) |
reviewbot | |
E501 line too long (105 > 79 characters) |
reviewbot | |
E501 line too long (118 > 79 characters) |
reviewbot | |
E501 line too long (109 > 79 characters) |
reviewbot | |
E501 line too long (108 > 79 characters) |
reviewbot | |
E501 line too long (84 > 79 characters) |
reviewbot | |
E501 line too long (117 > 79 characters) |
reviewbot | |
E501 line too long (110 > 79 characters) |
reviewbot | |
E501 line too long (103 > 79 characters) |
reviewbot | |
E501 line too long (86 > 79 characters) |
reviewbot | |
E501 line too long (87 > 79 characters) |
reviewbot | |
E501 line too long (95 > 79 characters) |
reviewbot | |
E501 line too long (108 > 79 characters) |
reviewbot | |
E501 line too long (114 > 79 characters) |
reviewbot | |
E127 continuation line over-indented for visual indent |
reviewbot | |
E122 continuation line missing indentation or outdented |
reviewbot | |
E122 continuation line missing indentation or outdented |
reviewbot | |
W291 trailing whitespace |
reviewbot | |
E501 line too long (94 > 79 characters) |
reviewbot | |
E501 line too long (95 > 79 characters) |
reviewbot | |
E501 line too long (88 > 79 characters) |
reviewbot | |
W291 trailing whitespace |
reviewbot | |
E501 line too long (114 > 79 characters) |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
W291 trailing whitespace |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E501 line too long (80 > 79 characters) |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E501 line too long (86 > 79 characters) |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E501 line too long (99 > 79 characters) |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E501 line too long (90 > 79 characters) |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E501 line too long (89 > 79 characters) |
reviewbot | |
W291 trailing whitespace |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E501 line too long (98 > 79 characters) |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E501 line too long (91 > 79 characters) |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
E501 line too long (84 > 79 characters) |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot |
- Commits:
-
Summary ID Author 352a64ace63a60611d8ba9e4f34c863993767206 ruonan 352a64ace63a60611d8ba9e4f34c863993767206 ruonan 7567584c5a4107df57f51d9c76da4c3a5ee0aa6c ruonan ede798a8298879061ddc930cf0c4b1bf22fd03ba ruonan
Checks run (1 failed, 1 succeeded)
flake8
- Commits:
-
Summary ID Author 352a64ace63a60611d8ba9e4f34c863993767206 ruonan 7567584c5a4107df57f51d9c76da4c3a5ee0aa6c ruonan ede798a8298879061ddc930cf0c4b1bf22fd03ba ruonan 02bcf3e41c18b01d6e3e11cfbfaeafd86b2f7d94 ruonan
Checks run (1 failed, 1 succeeded)
flake8
-
Warning: Showing 30 of 98 failures.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- Summary:
-
[WIP] - Add Matrix Chat option to IntegrationAdd Matrix Chat option to Integration
- Description:
-
~ [WIP] - Add Matrix Chat option to Integration
~ Admins can choose to add Matrix Integration. This will send notifications to the registered matrix room about new review requets and updates to existing ones.
- Testing Done:
-
+ Tested in RB4.
+ Edited Slack unit test cases to test Matrix integration. All tests have passed except 2 of then complaining about missing image attachment + tests with errors are: + - test_notify_new_review_request_with_image_file_attachment + - test_notify_updated_review_request_with_new_image_attachments
- Commits:
-
Summary ID Author 02bcf3e41c18b01d6e3e11cfbfaeafd86b2f7d94 ruonan 74667fd4436679bf110ca1d3a13770c02b70c41d ruonan
Checks run (1 failed, 1 succeeded)
flake8
-
Warning: Showing 30 of 90 failures.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- Commits:
-
Summary ID Author 74667fd4436679bf110ca1d3a13770c02b70c41d ruonan d7b7ad12cd24fa01bf0001c97d262e552e6f0562 ruonan
Checks run (1 failed, 1 succeeded)
flake8
-
Warning: Showing 30 of 81 failures.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-