Fix CircleCI build not running on personal GitHub repositories.

Review Request #11190 — Created Sept. 19, 2020 and submitted — Latest diff uploaded

Information

rbintegrations
master

Reviewers

Fix CircleCI build not running on personal GitHub repositories.

CircleCI pipelines were not running for personal GitHub repositories when
a review request is made because the GitHub username was being extracted
from the wrong place.

RBIntegrations was pulling the wrong key from extra_data and it's been
updated to grab the associated HostingService's username.

This patch depends on /r/11198 and /r/11204 for the unit tests to pass.

Manual testing: A personal public and private repository was set up and
integrated with CircleCI. They are confirmed to be running without using
Review Board. Then, a review request was made for both the repositories.
Using the CircleCI web UI, the pipelines were triggered.

Unit tests were created to verify that the username is being pulled
from the correct place for the 4 different GitHub repository plans.
These were ran on Review Board 3.0 and Review Board 4.0 and their
supported versions of Python.

Diff Revision 7 (Latest)

orig
1
2
3
4
5
6
7

Commits

First Last Summary ID Author
Fix CircleCI not running on personal GitHub repos.
00999ad311dbeb178fa70a100da3d5cd265cc44d Marcus Boay
Add CircleCI different GitHub repository plan unit tests.
e788898d1f3a7f977a9b57d3504a63f6faa705df Marcus Boay
Refactor CircleCI tests to reduce duplication.
7a08a8b7e2a3e2622112a3d95484174e5f0cdc04 Marcus Boay
Fix types in CircleCI docstrings to Python types.
0ebb174f668ab7352f4c27454a78f1720c76537a Marcus Boay
rbintegrations/circleci/integration.py
rbintegrations/circleci/tests.py
Loading...