Fix empty review can be published bug.
Review Request #11185 — Created Sept. 19, 2020 and updated — Latest diff uploaded
When publishing a review, an empty review can be published and it will
show as a blank review.The
publish()
function of review has been updated to check for empty
text in a review's Header, Comment and Footer. When a review with empty
Header, Comment and Footer is being published, the function throws a
PublishError
. A review with onlyShip It
and no text is considered
to be valid and will not raise an error. Updated#982 Testing sending
e-mails and filtering out users not on a local site
to use a non-empty
Review as we now check for empty reviews.
Ran
runtests.py
, failed#788 Testing GitHub.authorize
. Tested on
browser to ensure the fix works on Web API.