Fix My Privacy Rights showing empty label.

Review Request #11180 — Created Sept. 18, 2020 and submitted — Latest diff uploaded

Information

Review Board
release-4.0.x

Reviewers

The "My Privacy Rights" page in the user account settings was showing an
orphaned :*. This was for the field label for the consent items, but that
form field didn't have a label defined. The cause here was that the Review
Board form field template was checking if the form had a fields_no_label
attribute, but that was deprecated and removed from Djblets a long time ago.
The correct fix is to check if the field has a label defined.

Manual testing by refreshing the My Privacy Rights page and checking that the
empty label is no longer visible. Other labels on the account forms that are
supposed to be there have been verified to be visible.

Doing a search of fields_no_label on all the reviewboard repositories show
no usage of that particular variable.

Commits

Files