Fix GitHub auth token bug using wrong HTTP header capitalization in Python2.7

Review Request #11173 — Created Sept. 17, 2020 and submitted — Latest diff uploaded

Information

Review Board
release-4.0.x

Reviewers

When trying to add a newly configured repo, it complained about the
GitHub Auth Token missing required permissions.

The underlying issue was that the wrong capitalization was used when
getting the OAuth scopes header for Python2.7.

Did the following with all relevant versions of Python3 and 2:

  • Ran unit tests and they passed

  • Manually added a repo with with a personal access token

Diff Revision 5 (Latest)

orig
1
2
3
4
5

Commits

First Last Summary ID Author
Normalize headers from GitHub for consistency in Python 2 and 3
d71bb40fba95823bd8afc846196986da26191112 HailanXyouknow
reviewboard/hostingsvcs/github.py
Loading...