Fix a couple problems in rbt post error handling.
Review Request #11142 — Created Aug. 18, 2020 and submitted — Latest diff uploaded
When rbt post encounters an error when creating the review request,
there were a couple problems that could manifest:
- The code that attempted to handle the case of updating an existing
review request on services that use changenums (perforce, plastic) was
using an old variable name, causing aNameError
. - The error message formatting for other types of
APIError
s was
passing the exception instance intoforce_unicode
, which only
accepts unicode or bytes. This has been changed to cast first to call
the__str__
method.
- Ran unit tests.
- Smoke tested rbt post error handling.