Clean up the Repository unit tests.

Review Request #11139 — Created Aug. 17, 2020 and submitted

Information

Review Board
release-4.0.x

Reviewers

The Repository unit tests are pretty old, and predated the modern spying
capabilities we enjoy today. They instead overrode much functionality,
and had crude ways of testing results. If anything were to break, these
could impact future unit tests.

This change is a small cleanup that moves over to using spies instead.
There's a few other small cleanups included, helping make these tests
more readable and maintainable going forward.

Unit tests pass.

Summary ID
Clean up the Repository unit tests.
The Repository unit tests are pretty old, and predated the modern spying capabilities we enjoy today. They instead overrode much functionality, and had crude ways of testing results. If anything were to break, these could impact future unit tests. This change is a small cleanup that moves over to using spies instead. There's a few other small cleanups included, helping make these tests more readable and maintainable going forward.
01acbb92986039d732cbc2dd02b24cbc12e7cc0e
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (90d4c96)