• 
      

    Fix submit-row visibility for new objects.

    Review Request #11134 — Created Aug. 10, 2020 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    The new change form was using default_if_none to specify the defaults
    for visibility of various buttons, but that doesn't do the right thing
    if the variables being checked just aren't defined at all in the
    context. This change fixes it to use default instead, and enables
    visibility of the "Save and add another" and "Save and continue editing"
    by default.

    Opened the admin form for creating new objects (repositories, users,
    groups) and saw that the submit row buttons were now visible.

    Summary ID
    Fix submit-row visibility for new objects.
    The new change form was using `default_if_none` to specify the defaults for visibility of various buttons, but that doesn't do the right thing if the variables being checked just aren't defined at all in the context. This change fixes it to use `default` instead, and enables visibility of the "Save and add another" and "Save and continue editing" by default. Testing Done: Opened the admin form for creating new objects (repositories, users, groups) and saw that the submit row buttons were now visible.
    7c62a4d75c6e28079c875d7b584b05ef720aeaec
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (663f50d)