• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Fix clicking on an extension's "Configure" button.
    
 
    

    



 
    
 
    

  Review Request #11117
  —
  Created Aug. 3, 2020 and submitted 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  Djblets
 
    

    





    
 
 
    
  release-2.0.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  djblets
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    The Configure action for extensions wasn't working, raising an error in
    
the JS console about attempting to call undefined. The way list item
    
actions work, if there's a handler defined it will attempt to call it,
    
but otherwise it will just act as a link. The inclusion of the handler
    
name for configure inside the actionHandlers object meant it was
    
trying the former, but we never had defined the method it referenced.
    
Removing this entry makes it a link again.
    
 
    

    





  

    
 
 
    
  
    Clicked "Configure" on an extension and saw it open the extension's
    
configuration UI.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    
      Fix clicking on an extension's "Configure" button.
      
    The Configure action for extensions wasn't working, raising an error in
the JS console about attempting to call `undefined`. The way list item
actions work, if there's a handler defined it will attempt to call it,
but otherwise it will just act as a link. The inclusion of the handler
name for `configure` inside the `actionHandlers` object meant it was
trying the former, but we never had defined the method it referenced.
Removing this entry makes it a link again.

Testing Done:
Clicked "Configure" on an extension and saw it open the extension's
configuration UI.
    
     
    

        		
    87e4792d158a9cd3c88661079bf0fd3441ee8285

   
    


      
 
    

    
    
 
    

    






 









 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 





 
    
  
    
   
    



chipx86




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
chipx86


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-2.0.x (b5d3fa0)