chipx86 got a fish trophy!

Summary

Don't crash if a bad LocalSite ID is posted in a LocalSite-aware form.

Review Request #11111 — Created Aug. 2, 2020 and submitted Aug. 6, 2020, 3:44 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

LocalSiteAwareModelFormMixin uses the LocalSite ID passed when
posting form data and validates all other relation fields against that.
An assumption is made that we can perform a query for a LocalSite
given that ID, and on some databases that works fine, but on others it
will raise an exception if the ID isn't numeric.

We now check for this ahead of time and ignore the value if provided,
avoiding a confusing crash.

Testing Done

Unit tests pass.

Verified the crash occurred without this fix but was fixed with it.

Commits

Summary	ID
Don't crash if a bad LocalSite ID is posted in a LocalSite-aware form. `LocalSiteAwareModelFormMixin` uses the `LocalSite` ID passed when posting form data and validates all other relation fields against that. An assumption is made that we can perform a query for a `LocalSite` given that ID, and on some databases that works fine, but on others it will raise an exception if the ID isn't numeric. We now check for this ahead of time and ignore the value if provided, avoiding a confusing crash.	e149fa5dd07f6cea7b7845a95fbe3ff00caf7a0e

Summary

Don't crash if a bad LocalSite ID is posted in a LocalSite-aware form.

`LocalSiteAwareModelFormMixin` uses the `LocalSite` ID passed when posting form data and validates all other relation fields against that. An assumption is made that we can perform a query for a `LocalSite` given that ID, and on some databases that works fine, but on others it will raise an exception if the ID isn't numeric. We now check for this ahead of time and ignore the value if provided, avoiding a confusing crash.

e149fa5dd07f6cea7b7845a95fbe3ff00caf7a0e

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (377026e)