Summary

Fix broken parser for git diffs with binaries

Review Request #11100 — Created July 28, 2020 and submitted Aug. 13, 2020, 9:53 a.m.

Information

Owner

misery

Repository

Review Board

Branch

release-3.0.x

Bugs

4638

Depends On

Reviewers

Groups

reviewboard

People

Description

The parser for git diffs (git and hg) did a mistake if there are base64
binary data. It prepended the data to a following file info instead of
appending the previous one.

Cherry-pick of 4e507d418c3420cf49667340f44f82347e845313
Replaced io.BytesIO by StringIO()

Testing Done

flake8 passed.

JSHint passed.

Description:: The parser for git diffs (git and hg) did a mistake if there are base64
binary data. It prepended the data to a following file info instead of
appending the previous one.

Cherry-pick of 4e507d418c3420cf49667340f44f82347e845313
Replaced io.BytesIO by StringIO()
-
-
Bugs closed: 4638
Bugs:: 4638

Looks like a good fix. I'm going to spend some time going through this and running some internal tests, but we should be able to get this into 3.0.19.

misery July 28, 2020, 11:10 p.m.

Yeah, of course.
https://reviews.reviewboard.org/r/10854/#review36892 :-)

Status:: Discarded

Ship it!

```
Ship It!
```

		The parser for git diffs (git and hg) did a mistake if there are base64
		binary data. It prepended the data to a following file info instead of
		appending the previous one.

		Cherry-pick of 4e507d418c3420cf49667340f44f82347e845313
		Replaced io.BytesIO by StringIO()
-
-		Bugs closed: 4638