Update the Search Settings page for modern subform support.

Review Request #11064 — Created July 3, 2020 and submitted

Information

Review Board
release-4.0.x

Reviewers

The Search Settings page has been updated to work with the subform
support introduced in Review Board 4.0. This gives us a maintainable way
of allowing authentication forms to be added to the page and configured
without triggering any browser-side validation issues for unselected
subforms.

Tested saving the search form with each search backend subform selection.
Verified that only the selected subforms received any client-side or
server-side validation, and that settings loaded and saved.

Summary ID
Update the Search Settings page for modern subform support.
The Search Settings page has been updated to work with the subform support introduced in Review Board 4.0. This gives us a maintainable way of allowing authentication forms to be added to the page and configured without triggering any browser-side validation issues for unselected subforms.
a949f5c3f0374cc323078740573e4643af8395c2
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (3e05669)