Make "rbt patch" use the review request details when there's one commit.

Review Request #11019 — Created May 13, 2020 and submitted

Information

RBTools
release-2.0.x

Reviewers

When using "rbt patch" to apply a change from a review request that was
created with history, it uses the commit message as the message for the
new commit that it's creating. This is ideal when applying a review
request that has multiple commits (since it pulls in all of the messages
for each commit in turn), but it didn't feel right for the simpler case
of applying a change with a single commit. In order to maintain the same
behavior as before, we now use the review request details as the commit
message when there's only one commit.

Verified that after this change, rbt patch -c used the review request
details as the commit message instead of the commit metadata.

Summary ID
Make "rbt patch" use the review request details when there's one commit.
When using "rbt patch" to apply a change from a review request that was created with history, it uses the commit message as the message for the new commit that it's creating. This is ideal when applying a review request that has multiple commits (since it pulls in all of the messages for each commit in turn), but it didn't feel right for the simpler case of applying a change with a single commit. In order to maintain the same behavior as before, we now use the review request details as the commit message when there's only one commit. Testing Done: Verified that after this change, `rbt patch -c` used the review request details as the commit message instead of the commit metadata.
b5f6c769e8f29cae6f32f7014ace707a579dda5a
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (916cfe4)
Loading...