Update unit tests to not use fat arrow functions for Jasmine methods.
Review Request #11010 — Created May 6, 2020 and submitted — Latest diff uploaded
When we first moved the codebase to ES6, we were using fat arrow
functions in calls tosuite()
,describe()
,it()
, and
beforeEach()
, which appeared to make sense at the time. However,
Jasmine actually intentionally provides an explicitthis
value used
for test context. We don't really use it in practice, but we don't want
to override it, and we're not supposed to be passing in fat arrow
functions to any of these calls.This change simply replaces all
=> { ... }
in Jasmine calls with
function() { ... }
.
Unit tests pass.