Add a new RB.Product constant for product information.

Review Request #10947 — Created March 10, 2020 and submitted

Information

Review Board
release-4.0.x
2f004a3...

Reviewers

This introduces RB.Product, which contains information on the product
name, version (human-readable and raw version information), release
status, and manual URL. This can be used by the JavaScript codebase for
some purposes (like looking up the manual URL, which was previously
doable with an old constant that's now deprecated), but its main use is
for extensions.

Extensions that need to alter behavior client-side based on the version
of Review Board can now do so by reading RB.Product.versionInfo. This
can be important given the differences between Review Board 3.0 and 4.0,
particularly in the administration UI.

The information is generated once per process and then cached in-process
for future lookups.

Loaded a couple pages and verified that RB.Product was generated and
contained the correct information.

Description From Last Updated

Shouldn't these keys start with a lower case letter? They're data, not namespaces.

daviddavid
chipx86
david
  1. 
      
  2. reviewboard/admin/templatetags/rbproduct.py (Diff revision 2)
     
     
     
     
     
     
    Show all issues

    Shouldn't these keys start with a lower case letter? They're data, not namespaces.

    1. True. I guess I was basing the names off RB.EnabledFeatures, which is using that casing.

  3. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (5196fc6)