Fix up a few odds and ends in the rbintegrations tests.

 






 

 


  Review Request #10940
  —
  Created March 5, 2020 and submitted 

 




















 

  

   Information

  





 
 

  david
 









 
 

  rbintegrations
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbintegrations
 









 
 

  
 






 








 





  


 
 

  
This change covers a few leftover issues in the rbintegrations test

suite that didn't fit neatly into other changes:


    

  • Some change in the way fixtures are loaded (probably in the new
    
  Django) was causing failures because we loaded the site fixtures
    
  before the user fixtures. Reordering the fixtures lists fixes this.
    • 

  • The API for AccountPageForm changed slightly, no longer saving a
    
  reference to the profile. The code has been changed to fetch it.
    • 

  • One of the tests regarding an unpublished review request wasn't
    
  working correctly unless I changed which user was logged in. I'm not
    
  sure why it worked before, honestly.
    • 


 








  


 
 

  
Ran rbintegrations tests.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Fix up a few odds and ends in the rbintegrations tests.
      
This change covers a few leftover issues in the rbintegrations test
suite that didn't fit neatly into other changes:

- Some change in the way fixtures are loaded (probably in the new
  Django) was causing failures because we loaded the site fixtures
  before the user fixtures. Reordering the `fixtures` lists fixes this.
- The API for `AccountPageForm` changed slightly, no longer saving a
  reference to the profile. The code has been changed to fetch it.
- One of the tests regarding an unpublished review request wasn't
  working correctly unless I changed which user was logged in. I'm not
  sure why it worked before, honestly.

Testing Done:
Ran rbintegrations tests.

     


    		
    678dc1651469725b2486c370d7863ca0b027b2f6

   



  
 




 













 









 






  

 



















 




 




 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to master (ed7aed9)