Summary

Fix up a few odds and ends in the rbintegrations tests.

Review Request #10940 — Created March 5, 2020 and submitted March 11, 2020, 3:46 p.m.

Information

Owner

david

Repository

rbintegrations

Branch

master

Bugs

Depends On

Reviewers

Groups

rbintegrations

People

Description

This change covers a few leftover issues in the rbintegrations test
suite that didn't fit neatly into other changes:

Some change in the way fixtures are loaded (probably in the new
Django) was causing failures because we loaded the site fixtures
before the user fixtures. Reordering the fixtures lists fixes this.
The API for AccountPageForm changed slightly, no longer saving a
reference to the profile. The code has been changed to fetch it.
One of the tests regarding an unpublished review request wasn't
working correctly unless I changed which user was logged in. I'm not
sure why it worked before, honestly.

Testing Done

Ran rbintegrations tests.

Commits

Summary	ID
Fix up a few odds and ends in the rbintegrations tests. This change covers a few leftover issues in the rbintegrations test suite that didn't fit neatly into other changes: - Some change in the way fixtures are loaded (probably in the new Django) was causing failures because we loaded the site fixtures before the user fixtures. Reordering the `fixtures` lists fixes this. - The API for `AccountPageForm` changed slightly, no longer saving a reference to the profile. The code has been changed to fetch it. - One of the tests regarding an unpublished review request wasn't working correctly unless I changed which user was logged in. I'm not sure why it worked before, honestly. Testing Done: Ran rbintegrations tests.	678dc1651469725b2486c370d7863ca0b027b2f6

Summary

Fix up a few odds and ends in the rbintegrations tests.

This change covers a few leftover issues in the rbintegrations test suite that didn't fit neatly into other changes: - Some change in the way fixtures are loaded (probably in the new Django) was causing failures because we loaded the site fixtures before the user fixtures. Reordering the `fixtures` lists fixes this. - The API for `AccountPageForm` changed slightly, no longer saving a reference to the profile. The code has been changed to fetch it. - One of the tests regarding an unpublished review request wasn't working correctly unless I changed which user was logged in. I'm not sure why it worked before, honestly. Testing Done: Ran rbintegrations tests.

678dc1651469725b2486c370d7863ca0b027b2f6

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (ed7aed9)