Summary

Fix up some unicode problems in rbintegrations.

Review Request #10939 — Created March 5, 2020 and submitted March 23, 2020, 9:30 a.m.

Information

Owner

david

Repository

rbintegrations

Branch

master

Bugs

Depends On

Reviewers

Groups

rbintegrations

People

Description

Most of rbintegrations was written with Python 3's unicode changes in
mind, but there were still a couple problems, mostly in unit test
implementations. This change fixes those up.

Testing Done

Ran rbintegrations tests on both Python 2 and 3.

Commits

Summary	ID
Fix up some unicode problems in rbintegrations. Most of rbintegrations was written with Python 3's unicode changes in mind, but there were still a couple problems, mostly in unit test implementations. This change fixes those up. Testing Done: Ran rbintegrations tests on both Python 2 and 3.	7acc9b71e1509b765838ef078800b75c123e2310

Issues

Description	From	Last Updated
we might want to compare against None directly, otherwise a u'' could slip in.	chipx86	March 11, 2020, 3:45 p.m.

flake8 passed.

JSHint passed.

```
Ship It!
```

Commits:

	Summary	ID
	Fix up some unicode problems in rbintegrations. Most of rbintegrations was written with Python 3's unicode changes in mind, but there were still a couple problems, mostly in unit test implementations. This change fixes those up. Testing Done: Ran rbintegrations tests on both Python 2 and 3.	52e36f65572fd933873c26aa5c4fb557c7ba6163
	Fix up some unicode problems in rbintegrations. Most of rbintegrations was written with Python 3's unicode changes in mind, but there were still a couple problems, mostly in unit test implementations. This change fixes those up. Testing Done: Ran rbintegrations tests on both Python 2 and 3.	88e7a48b66a5381f1ca609dfeec7a1f88a65036c

Diff:

Revision 2 (+12 -8)

Show changes

	rbintegrations/circleci/tests.py
	rbintegrations/idonethis/utils.py
	rbintegrations/travisci/integration.py
	rbintegrations/travisci/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbintegrations/idonethis/utils.py (Diff revision 2)

The issue has been resolved. Show all issues

we might want to compare against None directly, otherwise a u'' could slip in.

Commits:

	Summary	ID
	Fix up some unicode problems in rbintegrations. Most of rbintegrations was written with Python 3's unicode changes in mind, but there were still a couple problems, mostly in unit test implementations. This change fixes those up. Testing Done: Ran rbintegrations tests on both Python 2 and 3.	88e7a48b66a5381f1ca609dfeec7a1f88a65036c
	Fix up some unicode problems in rbintegrations. Most of rbintegrations was written with Python 3's unicode changes in mind, but there were still a couple problems, mostly in unit test implementations. This change fixes those up. Testing Done: Ran rbintegrations tests on both Python 2 and 3.	7acc9b71e1509b765838ef078800b75c123e2310

Diff:

Revision 3 (+14 -10)

Show changes

	rbintegrations/circleci/tests.py
	rbintegrations/idonethis/utils.py
	rbintegrations/travisci/integration.py
	rbintegrations/travisci/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (06797f4)