Fix a bug in the RB.UploadAttachmentView refactoring change
Review Request #10937 — Created March 4, 2020 and submitted — Latest diff uploaded
The change e94bac071aa42fa45ad30d92f975d6d7c114e16a was landed prematurely and introduced
a some regressions. Some of them were fixed in 3a74bdfaee929403eb7ada0c38d286e6c27d0d20 but
a couple remained.In
RB.UploadAttachmentView
, theoptions
ininitialize
needs to be defaulted to an
empty object to prevent reference errors. In addition, the function was referencing
this.presetCaption
andthis.attachmentHistory
, which were undefined. This caused the
dialog to have a blank caption when file attachments were updated.
- dialogView unit tests still pass
Manual testing:
Adding a file attachment:
- opening the dialog, uploading a file, and submitting it (without editing the caption)
- opening the dialog, uploading a file, editing the caption, and submitting it
- opening the dialog, editing the caption, uploading a file, and submitting it
- opening the dialog, uploading a file, then cancelling the dialog
- opening the dialog, editing the caption, then cancelling the dialog
- opening the dialog, then cancelling the dialog without uploading anything
- verified the 'Upload' button is disabled unless a file is actually uploaded
Updating a file attachment:
- editing the caption for a file attachment inline and then opening the update dialog
to check that the caption is consistent
- opening the update dialog and cancelling the dialog without uploading anything new
- updating a file attachment without changing the caption
- updating a file attachment and changing the caption
- verified the 'Upload' button is disabled unless a new file is actually uploaded