Tab-based shortcuts on review request page fields.

 






 

 


  Review Request #10929
  —
  Created Feb. 29, 2020 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  LittleGrey
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  10913
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This review request is for the 2nd part of "selecting review request

field" project. The goal of this project is to have tab-based keybaord

shortcuts on review request page fields. (e.g., hitting tab-d focuses 

"Description" field).


This project is dependent on "Keyboard shortcut registry"


The project includes a ShortcutHelpDialog which dynamically renders

available keyboard shortcuts on each page as well as their descriptions.

A screenshot is attached below.

 








  


 
 

  
Press tab and h on review request page and the dialog is shown (the

shortcuts are displayed as well).


Press tab and d on review request page and Description field is

focused.


Press tab and h on dashboard page and the help dialog is shown.


All unit tests passed.

 







 









 





  








 




 







   

    
    
Changes between revision 5 and 6



    

 

 

 

 
orig
1
2
3
4
5
6
7

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    
Add a keyboard shortcut central registry for page views.

   
  		
  7c6dbaac53155d9254f8bbff944da5f06735c2d3
  Jay
 


 
  
 
 
  
   
    
Remove one extra  space.

   
  		
  94475ce07d634af284836ba6dc32e824b6992734
  Jay
 


 
  
 
 
  
   
    
Add missing semicolon.

   
  		
  e1654205949a0b7914eecfd19b1651f78647213a
  Jay
 


 
  
 
 
  
   
    
Remove console.log and change some wording.

   
  		
  f563e3d5253e205ac1682954514aa70ff6e6c07b
  Jay
 


 
  
 
 
  
   
    
Use extend instead of overwriting.

   
  		
  14c32b571c03a585fdb7f7aae82a834ba51e3c85
  Jay
 


 
  
 
 
  
   
    
Made keyBindings comments more clear.

   
  		
  566b35317b1314e0292fa75b09b07797cb9e78e4
  Jay
 


 
  
 
 
  
   
    
[WIP] Tab-based shortcuts on review request page fields.

   
  		
  5b91e87c3b4380d2921afc88df96a093c654d149
  Jay
 


 
  
 
 
  
   
    
Remove traling spaces.

   
  		
  c225288a74c8a0de0d8370bb397e0529ab973eaa
  Jay
 


 
  
 
 
  
   
    
[WIP] Tab-based shortcuts on review request page.

   
  		
  ebebb8f7bbfcb7a9aef57e7c080987ff273b2bd8
  Jay
 


 
  
 
 
  
   
    
Dynamically render keyboard shortcuts on each page

   
  		
  8b1661ea6b1c4ca0ffc0e46c158c74cfd7dac21e
  Jay
 


 
  
 
 
  
   
    
Better styles on shortcur help dialog.

   
  		
  d545fc87bc29c4c94c4072219c03aeabbda0f058
  Jay
 


 
  
 
 
  
   
    
Tab based shortcuts selecting fields & unit tests.

   
  		
  ba12dca4b8e547a61ebc47610bb228f4206982a5
  Jay
 


 
  
 
 
  
   
    
Add a keyboard shortcut central registry for page views.

   
  		
  20d4da8c4268f33c102486061da94fc8a66af18c
  Jay
 


 
  
 
 
  
   
    
Remove one extra  space.

   
  		
  ff48beaa3d798a3d2fe07b612c7d561064db47f7
  Jay
 


 
  
 
 
  
   
    
Add missing semicolon.

   
  		
  a324636d864dd8215f692e85425d4e2cef4d0ef4
  Jay
 


 
  
 
 
  
   
    
Remove console.log and change some wording.

   
  		
  18847f629b301aeb2de567989234ed6690b0b73a
  Jay
 


 
  
 
 
  
   
    
Use extend instead of overwriting.

   
  		
  6e8c74bbf63591f72a84589f93add4a54a063020
  Jay
 


 
  
 
 
  
   
    
Made keyBindings comments more clear.

   
  		
  a2a94100711811603e545a28e1d2ce5c37db92dd
  Jay
 


 
  
 
 
  
   
    
[WIP] Tab-based shortcuts on review request page fields.

   
  		
  1c9b40db935e92a8239a869cbbe14f5cf1388a10
  Jay
 


 
  
 
 
  
   
    
Remove traling spaces.

   
  		
  538fe4586645ff2d69019858bd33e90c9edacf62
  Jay
 


 
  
 
 
  
   
    
[WIP] Tab-based shortcuts on review request page.

   
  		
  a215d8037abd54564052af460459467f9c164ca6
  Jay
 


 
  
 
 
  
   
    
Dynamically render keyboard shortcuts on each page

   
  		
  f0a4818f3dd6714626210881a0cf756f2873928a
  Jay
 


 
  
 
 
  
   
    
Better styles on shortcur help dialog.

   
  		
  025f1a15417988514668e3f4d1c8ffd5da988a74
  Jay
 


 
  
 
 
  
   
    
Tab based shortcuts selecting fields & unit tests.

   
  		
  12de8777b68d977c3f5da45af4cac9eebe0487c2
  Jay
 


 
  
 
 
  
   
    
Unit tests done.

   
  		
  9ee4a792a8e1659f08a965ef0ad488b07286acb4
  Jay
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/staticbundles.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/pages/views/basePageView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/pages/views/tests/basePageViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/tests/shortcutHelpDialogViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/utils/tests/keyBindingUtilsTests.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...