Tab-based shortcuts on review request page fields.

Review Request #10929 — Created Feb. 29, 2020 and updated — Latest diff uploaded

Information

Review Board
master

Reviewers

This review request is for the 2nd part of "selecting review request
field" project. The goal of this project is to have tab-based keybaord
shortcuts on review request page fields. (e.g., hitting tab-d focuses
"Description" field).

This project is dependent on "Keyboard shortcut registry"

The project includes a ShortcutHelpDialog which dynamically renders
available keyboard shortcuts on each page as well as their descriptions.
A screenshot is attached below.

Press tab and h on review request page and the dialog is shown (the
shortcuts are displayed as well).

Press tab and d on review request page and Description field is
focused.

Press tab and h on dashboard page and the help dialog is shown.

All unit tests passed.

Diff Revision 4

This is not the most recent revision of the diff. The latest diff is revision 7. See what's changed.

orig
1
2
3
4
5
6
7

Commits

First Last Summary ID Author
Add a keyboard shortcut central registry for page views.
62a05c8b533e6460c38ab0dbcbcd90e59fb8ea4b Jay
Remove one extra space.
2c731c42f114684a9d28b02db306d384cebd23d8 Jay
Add missing semicolon.
eef2c16a04bbf0ffd0c0ed2853dc805a5a0c211a Jay
Remove console.log and change some wording.
a301a25923ad03ba08f68360e8203167acb20bf2 Jay
Use extend instead of overwriting.
10bf8f9a35233be9f9ef0cd2bac033ce9ba2fa18 Jay
Made keyBindings comments more clear.
d46c9fb052ac011b5fa01054b9c2463b15d1dd1b Jay
[WIP] Tab-based shortcuts on review request page fields.
d67137093a82fae7b536f7dc1e1f01f60eec8c73 Jay
Remove traling spaces.
0aa3cec05c64a45177ff07025ebfb90db15b44d3 Jay
[WIP] Tab-based shortcuts on review request page.
0fb02faaa9a34e9d87b5ae9c3846c1a3e4160576 Jay
Dynamically render keyboard shortcuts on each page
eee4b69cafa04f4b6ada4662172f7d264823020c Jay
Better styles on shortcur help dialog.
20c64907abb9aaac171588f906a1b20743e17013 Jay
reviewboard/staticbundles.py
reviewboard/static/rb/css/common.less
reviewboard/static/rb/js/pages/views/basePageView.es6.js
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js
reviewboard/static/rb/js/reviewRequestPage/views/reviewRequestPageView.es6.js
reviewboard/static/rb/js/ui/views/shortcutHelpDialogView.es6.js
reviewboard/static/rb/js/utils/keyBindingUtils.es6.js
Loading...