Tab-based shortcuts on review request page fields.

Review Request #10929 — Created Feb. 29, 2020 and updated — Latest diff uploaded

Information

Review Board
master

Reviewers

This review request is for the 2nd part of "selecting review request
field" project. The goal of this project is to have tab-based keybaord
shortcuts on review request page fields. (e.g., hitting tab-d focuses
"Description" field).

This project is dependent on "Keyboard shortcut registry"

The project includes a ShortcutHelpDialog which dynamically renders
available keyboard shortcuts on each page as well as their descriptions.
A screenshot is attached below.

Press tab and h on review request page and the dialog is shown (the
shortcuts are displayed as well).

Press tab and d on review request page and Description field is
focused.

Press tab and h on dashboard page and the help dialog is shown.

All unit tests passed.

Diff Revision 3

This is not the most recent revision of the diff. The latest diff is revision 7. See what's changed.

orig
1
2
3
4
5
6
7

Commits

First Last Summary ID Author
Add a keyboard shortcut central registry for page views.
692bc1de7b67381c93c5ea43f031c9eee157f184 Jay
Remove one extra space.
244c704e94e9e34347509d48363c7f501a68692c Jay
Add missing semicolon.
f58b9c2186cf338a9865dfcbd662afda47aa3d62 Jay
Remove console.log and change some wording.
48d8216594744ff5250794a3640ddc3a14274357 Jay
Use extend instead of overwriting.
6f371824fd0811f94e8e277e3d696913b1cf92c6 Jay
Made keyBindings comments more clear.
fe08e14bff73d7aa8b9df48886a0920d730bbc9d Jay
[WIP] Tab-based shortcuts on review request page fields.
62258b670d02dad0fee90931ee62ddd9e69126b7 Jay
Remove traling spaces.
892c7dfbb1d3d29d2f305a665e58cd705a080b49 Jay
[WIP] Tab-based shortcuts on review request page.
7d537165aea174b6a11e1c6e9752bdb342effa5f Jay
Dynamically render keyboard shortcuts on each page
a277f8cd7e1c60cf164a6200052a6d33ac84bbc1 Jay
reviewboard/staticbundles.py
reviewboard/static/rb/css/common.less
reviewboard/static/rb/js/pages/views/basePageView.es6.js
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js
reviewboard/static/rb/js/reviewRequestPage/views/reviewRequestPageView.es6.js
reviewboard/static/rb/js/ui/views/shortcutHelpDialogView.es6.js
reviewboard/static/rb/js/utils/keyBindingUtils.es6.js
Loading...