Tab-based shortcuts on review request page fields.

 






 

 


  Review Request #10929
  —
  Created Feb. 29, 2020 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  LittleGrey
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  10913
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This review request is for the 2nd part of "selecting review request

field" project. The goal of this project is to have tab-based keybaord

shortcuts on review request page fields. (e.g., hitting tab-d focuses 

"Description" field).


This project is dependent on "Keyboard shortcut registry"


The project includes a ShortcutHelpDialog which dynamically renders

available keyboard shortcuts on each page as well as their descriptions.

A screenshot is attached below.

 








  


 
 

  
Press tab and h on review request page and the dialog is shown (the

shortcuts are displayed as well).


Press tab and d on review request page and Description field is

focused.


Press tab and h on dashboard page and the help dialog is shown.


All unit tests passed.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2
3
4
5
6
7

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    
Add a keyboard shortcut central registry for page views.

   
  		
  3dec5902e36f9da5eec25993418c4e88c667f80a
  Jay
 


 
  
 
 
  
   
    
Remove one extra  space.

   
  		
  3d82ba3525b1f48711372952ec94389951542d70
  Jay
 


 
  
 
 
  
   
    
Add missing semicolon.

   
  		
  5acf1f77a465eb609535fade44747d64bbd5e00e
  Jay
 


 
  
 
 
  
   
    
Remove console.log and change some wording.

   
  		
  e63693dc2281dd08feaf4957f3ab57717c50a342
  Jay
 


 
  
 
 
  
   
    
Use extend instead of overwriting.

   
  		
  699106b138a1736c497fdb1ed23c5cbdd20d5605
  Jay
 


 
  
 
 
  
   
    
[WIP] Tab-based shortcuts on review request page fields.

   
  		
  564f1a61bd0833e912ffda3a11a4aad4ac703656
  Jay
 


 
  
 
 
  
   
    
Remove traling spaces.

   
  		
  8616a7627c0439a2ae52d5f8fafc0ac993f97a8d
  Jay
 


 
  
 
 
  
   
    
Add a keyboard shortcut central registry for page views.

   
  		
  5967295b5e9f0e38d0f3f1515d2772de918f5096
  Jay
 


 
  
 
 
  
   
    
Remove one extra  space.

   
  		
  fd424c91a0e592c0b5f11dbb1faa1e19c9741c4d
  Jay
 


 
  
 
 
  
   
    
Add missing semicolon.

   
  		
  bc2f57a1f2cba6524203bb3ae77274294e979006
  Jay
 


 
  
 
 
  
   
    
Remove console.log and change some wording.

   
  		
  ddafc7b61e713fcf655dfc27ad93f8de12e94e6f
  Jay
 


 
  
 
 
  
   
    
Use extend instead of overwriting.

   
  		
  99f8bedd5fd6b9813e4bfc117efcd23b634ebb42
  Jay
 


 
  
 
 
  
   
    
Made keyBindings comments more clear.

   
  		
  f4147a3406a1b4d87cde33034a10c817d9628f13
  Jay
 


 
  
 
 
  
   
    
[WIP] Tab-based shortcuts on review request page fields.

   
  		
  a8679c7266cb03fc2399bf74b968dcfa2d8a4467
  Jay
 


 
  
 
 
  
   
    
Remove traling spaces.

   
  		
  3bdeb2c31a70dee756b17562ccc4a9a35654fa50
  Jay
 


 
  
 
 
  
   
    
[WIP] Tab-based shortcuts on review request page.

   
  		
  bfccd8c8ecaab3a3325a6e47d3d4a64144a386f9
  Jay
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/staticbundles.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/pages/views/basePageView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviewRequestPage/views/reviewRequestPageView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviewRequestPage/views/shortcutHelpDialogView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/utils/keyBindingUtils.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...