Summary

Fix up rbintegrations tests that use old trophies API.

Review Request #10921 — Created Feb. 26, 2020 and submitted March 6, 2020, 9:48 a.m.

Information

Owner

david

Repository

rbintegrations

Branch

release-1.0.x

Bugs

Depends On

Commit

d222bf4...

Reviewers

Groups

rbintegrations

People

Description

Review Board 3.0 changed the trophies registry to actually use a real
registry instead of ad-hoc register and unregister methods, and
deprecated the old API. This was then removed entirely in Review Board
4. This change updates the unit tests to use that new API.

Testing Done

Ran rbintegrations tests.

Issues

Description	From	Last Updated
Looks like Review Board 3.0 actually introduced trophies_registry. We just weren't using it, but we deprecated in 3.0.	chipx86	March 5, 2020, 10:23 a.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Looks like Review Board 3.0 actually introduced trophies_registry. We just weren't using it, but we deprecated in 3.0.

chipx86 Feb. 28, 2020, 1:27 p.m.

In fact, given that, we should put this on release-1.0.x, so we won't emit deprecation warnings there.

Description:

~		Review Board 4 changed the trophies registry to actually use a real
~		registry instead of ad-hoc register and unregister methods. This change
~		updates the unit tests to use that new API.
	~	Review Board 3.0 changed the trophies registry to actually use a real
	~	registry instead of ad-hoc register and unregister methods, and
	~	deprecated the old API. This was then removed entirely in Review Board
	+	4. This change updates the unit tests to use that new API.

Branch:

master

release-1.0.x

Commit:

0e8a4071997d1f63500fa438daedb4a4eaff81eb

d222bf4a9854ddca262dc244a36e8a17b39688ca

Diff:

Revision 2 (+6 -8)

Show changes

	rbintegrations/mattermost/tests.py
	rbintegrations/slack/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.0.x (6d18f2e)