Summary

WIP Review request blank state project codebase exploration

Review Request #10903 — Created Feb. 15, 2020 and discarded Feb. 29, 2020, 2:48 p.m.

Information

Owner

bui1

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add a edit icon beside the files section

Default Fields are defined in builtin_fields.py, fields.py is defines field behaviour,
review_request_box.js gets all the fields in the review request and renders it to the ReviewRequestEditorView.es6.js.
review_request_box.html is where the draft review request template page is defined.

Testing Done

Commits

Summary	ID	Author
WIP Add comments for review request blank state methodology proposal	df1be329d2da57fb4ee7c3c399f2278d4adb84e6	bui1@ualberta.ca

Issues

Description	From	Last Updated
E402 module level import not at top of file	reviewbot	Feb. 29, 2020, 2:34 p.m.
E501 line too long (93 > 79 characters)	reviewbot	Feb. 29, 2020, 2:34 p.m.

flake8 passed.

JSHint passed.

Summary:

WIP Add comments for review request blank state methodology proposal

WIP Review request blank state project codebase exploration

Description:

~		WIP Add comments for review request blank state methodology proposal
	~	Add a edit icon beside the files section
	+
	+	Default Fields are defined in `builtin_fields.py`, `fields.py` is defines field behaviour,
	+	`review_request_box.js` gets all the fields in the review request and renders it to the `ReviewRequestEditorView.es6.js`.
	+	`review_request_box.html` is where the draft review request template page is defined.

Commits:

	Summary	ID	Author
	WIP Add comments for review request blank state methodology proposal	a1948cc35176268bfb4815951826bb19cb18a6ad	bui1@ualberta.ca
	WIP Add comments for review request blank state methodology proposal	df1be329d2da57fb4ee7c3c399f2278d4adb84e6	bui1@ualberta.ca

Diff:

Revision 2 (+166 -60)

Show changes

	reviewboard/cmdline/rbext.py
	reviewboard/reviews/builtin_fields.py
	reviewboard/reviews/fields.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/review_request_draft.py
	reviewboard/static/rb/js/ui/views/inlineEditorView.es6.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js
	reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js
	5 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/cmdline/rbext.py (Diff revision 2)
An issue was opened. Show all issues
```
E402 module level import not at top of file
```
reviewboard/reviews/models/review_request_draft.py (Diff revision 2)
An issue was opened. Show all issues
```
E501 line too long (93 > 79 characters)
```

Status:: Discarded
Change Summary:: Issues with branch rebasing. So made another request for that