• 
      

    Update the Change Form template for improved form alert support.

    Review Request #10876 — Created Feb. 3, 2020 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    This rearranges the base template for the Change Form to prepare for
    some updates to some of the settings and model pages.

    The <form> is now the main container for the page's contents, and
    contains the alerts (such as for form errors) and the content box. This
    inverses the relationship these elements had before, in order to allow
    alerts to more easily interact with the form (providing additional form
    submission buttons, for instance).

    The form alerts now have their own block called form-alerts,
    positioned above the form content box. Templates that extend this
    template can more easily add their own alerts in a standard place.

    Tested along with some upcoming work on the repository configuration page.

    Summary ID
    Update the Change Form template for improved form alert support.
    This rearranges the base template for the Change Form to prepare for some updates to some of the settings and model pages. The `<form>` is now the main container for the page's contents, and contains the alerts (such as for form errors) and the content box. This inverses the relationship these elements had before, in order to allow alerts to more easily interact with the form (providing additional form submission buttons, for instance). The form alerts now have their own block called `form-alerts`, positioned above the form content box. Templates that extend this template can more easily add their own alerts in a standard place.
    f20778d9e2f5e197aaf53345a8aaaed3fb0492de
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (6c3732a)