• 
      

    Fix unit test regressions with Paramiko 2.7+.

    Review Request #10864 — Created Jan. 27, 2020 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    Paramiko 2.7 introduced new parsing logic for RSA/DSA private keys, and
    this logic is far more sensitive to newlines. We previously had our
    sample private keys for unit tests formatted with an initial blank line,
    and this completely throws off the new parsing. While one may argue
    that's something Paramiko should sort out, we're probably not doing the
    right thing by having an initial newline.

    This change simply gets rid of that newline, providing compatibility
    with all versions of Paramiko.

    Unit tests pass on Paramiko 2.6 (pre-parser updates) and 2.7.0/2.7.1
    (parser updates and parser fixes, respectively).

    Summary ID
    Fix unit test regressions with Paramiko 2.7+.
    Paramiko 2.7 introduced new parsing logic for RSA/DSA private keys, and this logic is far more sensitive to newlines. We previously had our sample private keys for unit tests formatted with an initial blank line, and this completely throws off the new parsing. While one may argue that's something Paramiko should sort out, we're probably not doing the right thing by having an initial newline. This change simply gets rid of that newline, providing compatibility with all versions of Paramiko.
    f7ca1ba68ecc82fb7accd238e25a9414935f220b
    anselina
    1. Ship It!
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (7d8867d)