Summary

Support buffer/memoryview types in Base64Field.

Review Request #10843 — Created Jan. 21, 2020 and submitted Jan. 21, 2020, 11:59 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Django can end up giving us a buffer (Python 2.x) or memoryview
(Python 3.x) value when instantiating a field from a row in the
database. This wasn't supported in Base64Field, and led to breakages
in one part of the administration UI.

This extends Base64Field to work correctly with a six.memoryview
(which maps to the correct type on both versions of Python). Unit tests
ensure that all the type-specific behavior will work correctly when
provided with these values.

Testing Done

Unit tests pass on all supported versions of Python.

Verified that I was able to load the objects in the administration UI
that were triggering this bug.

Commits

Summary	ID
Support buffer/memoryview types in Base64Field. Django can end up giving us a `buffer` (Python 2.x) or `memoryview` (Python 3.x) value when instantiating a field from a row in the database. This wasn't supported in `Base64Field`, and led to breakages in one part of the administration UI. This extends `Base64Field` to work correctly with a `six.memoryview` (which maps to the correct type on both versions of Python). Unit tests ensure that all the type-specific behavior will work correctly when provided with these values.	e318650a21f4807807b0d9fa73040b5219250ea8

Summary

Support buffer/memoryview types in Base64Field.

Django can end up giving us a `buffer` (Python 2.x) or `memoryview` (Python 3.x) value when instantiating a field from a row in the database. This wasn't supported in `Base64Field`, and led to breakages in one part of the administration UI. This extends `Base64Field` to work correctly with a `six.memoryview` (which maps to the correct type on both versions of Python). Unit tests ensure that all the type-specific behavior will work correctly when provided with these values.

e318650a21f4807807b0d9fa73040b5219250ea8

Issues

Description	From	Last Updated
F811 redefinition of unused 'test_unsaved_obj_with_base64_decoded_value' from line 122	reviewbot	Jan. 21, 2020, 1:50 a.m.
F811 redefinition of unused 'test_saved_obj_with_base64_decoded_value' from line 195	reviewbot	Jan. 21, 2020, 1:50 a.m.

flake8 failed.

JSHint passed.

flake8

djblets/db/tests/test_base64_field.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F811 redefinition of unused 'test_unsaved_obj_with_base64_decoded_value' from line 122
```
djblets/db/tests/test_base64_field.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F811 redefinition of unused 'test_saved_obj_with_base64_decoded_value' from line 195
```

Change Summary:

Fixed some duplicate unit test function names.

Commits:

	Summary	ID
	Support buffer/memoryview types in Base64Field. Django can end up giving us a `buffer` (Python 2.x) or `memoryview` (Python 3.x) value when instantiating a field from a row in the database. This wasn't supported in `Base64Field`, and led to breakages in one part of the administration UI. This extends `Base64Field` to work correctly with a `six.memoryview` (which maps to the correct type on both versions of Python). Unit tests ensure that all the type-specific behavior will work correctly when provided with these values.	56abe2d28a19d80ea32c0de3ee4475783354db7a
	Support buffer/memoryview types in Base64Field. Django can end up giving us a `buffer` (Python 2.x) or `memoryview` (Python 3.x) value when instantiating a field from a row in the database. This wasn't supported in `Base64Field`, and led to breakages in one part of the administration UI. This extends `Base64Field` to work correctly with a `six.memoryview` (which maps to the correct type on both versions of Python). Unit tests ensure that all the type-specific behavior will work correctly when provided with these values.	e318650a21f4807807b0d9fa73040b5219250ea8

Diff:

Revision 2 (+140 -6)

Show changes

	djblets/db/fields/base64_field.py
	djblets/db/tests/test_base64_field.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (469a0fa)