Empty reviews cannot be published

Review Request #10829 — Created Jan. 17, 2020 and discarded — Latest diff uploaded

Information

Review Board
release-4.0.x

Reviewers

Bug: empty reviews can be published, and draft review banner is shown when review is empty.
My change: a review cannot published if: "Ship it" is not checked & header is empty & no comment & footer is empty.

  1. Open an empty review dialog, and close it.
  2. Type something in header, click "cancel", then close the review dialog.
  3. Add a new comment, type something, click "cancel", then close the review dialog.
  4. Type something in footer, click "cancel", then close the review dialog.
  5. Type and save text in header & footer, add a non-empty comment, delete them all, then close the review dialog.

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

orig
1
2
3

Commits

First Last Summary ID Author
Fix the bug that empty reviews can be published
65df2674c186af9adc3dfe73c4da263f39855888 Xiaohui Liu
Addressing review feedbacks
1c07be301bafefbaa8ff0134de5d837e8b8dbd34 Xiaohui Liu
reviewboard/static/rb/js/views/reviewDialogView.es6.js
Loading...