Empty reviews cannot be published
Review Request #10829 — Created Jan. 17, 2020 and discarded — Latest diff uploaded
Bug: empty reviews can be published, and draft review banner is shown when review is empty.
My change: a review cannot published if: "Ship it" is not checked & header is empty & no comment & footer is empty.
- Open an empty review dialog, and close it.
- Type something in header, click "cancel", then close the review dialog.
- Add a new comment, type something, click "cancel", then close the review dialog.
- Type something in footer, click "cancel", then close the review dialog.
- Type and save text in header & footer, add a non-empty comment, delete them all, then close the review dialog.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.
orig
1
2
3
Commits
reviewboard/static/rb/js/views/reviewDialogView.es6.js |
---|