• 
      

    Empty reviews cannot be published

    Review Request #10829 — Created Jan. 17, 2020 and discarded — Latest diff uploaded

    Information

    Review Board
    release-4.0.x

    Reviewers

    Bug: empty reviews can be published, and draft review banner is shown when review is empty.
    My change: a review cannot published if: "Ship it" is not checked & header is empty & no comment & footer is empty.

    1. Open an empty review dialog, and close it.
    2. Type something in header, click "cancel", then close the review dialog.
    3. Add a new comment, type something, click "cancel", then close the review dialog.
    4. Type something in footer, click "cancel", then close the review dialog.
    5. Type and save text in header & footer, add a non-empty comment, delete them all, then close the review dialog.

    Commits

    Files