• 
      

    Fix rendering extension CSS/JS bundles on modern Django.

    Review Request #10785 — Created Nov. 4, 2019 and discarded

    Information

    Djblets
    release-2.0.x

    Reviewers

    When rendering CSS/JS bundles for extensions in a developer setup (with
    PIPELINE_ENABLED=False), the resulting HTML would be escaped, causing
    garbage on the page and preventing the bundles from loading. This was
    due to the lack of a mark_safe() when rendering source files within
    Pipeline (as that's normally handled later in their standard template
    tag process), and the modern behavior to automatically escape unless
    explicitly marked safe.

    This simply adds a mark_safe() around the resulting HTML, and
    introduces new unit tests to check for these conditions.

    Unit tests pass.

    No longer saw escaped HTML for bundles on the page.

    Description From Last Updated

    F821 undefined name 'mark_safe'

    reviewbotreviewbot
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    chipx86
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Discarded