Summary

Added Jupyter Notebooks rendered view.

Review Request #10761 — Created Oct. 21, 2019 and updated Nov. 9, 2019, 6:38 a.m.

Information

Owner

amalik2

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

There is also support for a difference viewer that highlights cells in
the notebook that were modified/added/deleted.

This was used as a reference for the format of .ipynb files:
https://github.com/jupyter/nbformat/blob/master/nbformat/v4/nbformat.v4.schema.json

Testing Done

1) I ran unit tests with Python2.7 and Python3.6
2) I tested viewing a file normally with both Python2.7 and Python3.6
3) I tested viewing revisions of a file in the difference viewer with both
Python2.7 and Python 3.6

Commits

Summary	ID	Author
Added Jupyter Notebooks rendered view.	a11c50c58e8aabd03b57db7ceeead326d7ec7e13	amalik2

Files

Issues

Description	From	Last Updated
E502 the backslash is redundant between brackets	reviewbot	Oct. 21, 2019, 3:14 a.m.
E128 continuation line under-indented for visual indent	reviewbot	Oct. 21, 2019, 3:14 a.m.
E502 the backslash is redundant between brackets	reviewbot	Oct. 21, 2019, 3:14 a.m.
E502 the backslash is redundant between brackets	reviewbot	Oct. 21, 2019, 3:14 a.m.
E128 continuation line under-indented for visual indent	reviewbot	Oct. 21, 2019, 3:14 a.m.
E502 the backslash is redundant between brackets	reviewbot	Oct. 21, 2019, 3:14 a.m.
E128 continuation line under-indented for visual indent	reviewbot	Oct. 21, 2019, 3:14 a.m.
E502 the backslash is redundant between brackets	reviewbot	Oct. 21, 2019, 3:14 a.m.
E128 continuation line under-indented for visual indent	reviewbot	Oct. 21, 2019, 3:14 a.m.
E128 continuation line under-indented for visual indent	reviewbot	Oct. 21, 2019, 3:14 a.m.
E502 the backslash is redundant between brackets	reviewbot	Oct. 21, 2019, 3:14 a.m.
E128 continuation line under-indented for visual indent	reviewbot	Oct. 21, 2019, 3:14 a.m.
F401 'django.utils.encoding.force_text' imported but unused	reviewbot	Oct. 21, 2019, 3:14 a.m.
E203 whitespace before ':'	reviewbot	Oct. 21, 2019, 3:14 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E502 the backslash is redundant between brackets
```
reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E502 the backslash is redundant between brackets
```
reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E502 the backslash is redundant between brackets
```
reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E502 the backslash is redundant between brackets
```
reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E502 the backslash is redundant between brackets
```
reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E502 the backslash is redundant between brackets
```
reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/reviews/ui/jupyterui.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django.utils.encoding.force_text' imported but unused
```
reviewboard/reviews/ui/jupyterui.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E203 whitespace before ':'
```

Commits:

Summary	ID	Author
Added Jupyter Notebooks rendered view.	0b6f123a1471763fd129ba27d368082964a8b02d	amalik2
Added Jupyter Notebooks rendered view.	0b6f123a1471763fd129ba27d368082964a8b02d	amalik2
fixed errors	89fc36ea05c2cec8efa9f18aedbce229cd87510a	amalik2

Diff:

Revision 2 (+998 -8)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/mimetypes.py
	reviewboard/reviews/tests/test_jupyter_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jupyterui.py
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/views/jupyterReviewableView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

Summary	ID	Author
Added Jupyter Notebooks rendered view.	0b6f123a1471763fd129ba27d368082964a8b02d	amalik2
fixed errors	89fc36ea05c2cec8efa9f18aedbce229cd87510a	amalik2
Added Jupyter Notebooks rendered view.	a11c50c58e8aabd03b57db7ceeead326d7ec7e13	amalik2

Diff:

Revision 3 (+1090)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/mimetypes.py
	reviewboard/reviews/tests/test_jupyter_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jupyterui.py
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/views/jupyterReviewableView.es6.js

Added Files:

Checks run (2 succeeded)

flake8 passed.

JSHint passed.