Summary

Implement RB Tools attaching binary file to diff.

Review Request #10728 — Created Sept. 26, 2019 and discarded Oct. 26, 2021, 1:50 p.m.

Information

Owner

perplex

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools, students

People

Description

Currently when binary files are upload for review RB simply says 'File
is a binary. Can't display content.'. This commit changes this to
actually include the binary file with the diff so that reviewers can
visually see the diff for a binary.

Testing Done

Commits

Summary	ID
Implement RB Tools attaching binary file to diff.	7056a6129641aaa0bc52d88968a14da5b23b9738
Address reviewbot comment. Splits up query line.	9c22b6ffeb0c80756306db4844b7f3a8f74a94af

Issues

Description	From	Last Updated
E501 line too long (114 > 79 characters)	reviewbot	Sept. 26, 2019, 5:39 p.m.
E501 line too long (83 > 79 characters)	reviewbot	Sept. 26, 2019, 5:40 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (114 > 79 characters)
```

Commits:

	Summary	ID
	Implement RB Tools attaching binary file to diff.	7056a6129641aaa0bc52d88968a14da5b23b9738
	Implement RB Tools attaching binary file to diff.	7056a6129641aaa0bc52d88968a14da5b23b9738
	Address reviewbot comment. Splits up query line.	9c22b6ffeb0c80756306db4844b7f3a8f74a94af

Diff:

Revision 2 (+2537 -2505)

Show changes

	rbtools/api/resource.py
	rbtools/commands/post.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/post.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (83 > 79 characters)
```

Description:: ~
Currently when binary files are upload for review RB simply says 'File is a binary. Can't display content.'. This commit changes this to actually include the binary file with the diff so that reviewers can visually see the diff for a binary.
~
Currently when binary files are upload for review RB simply says 'File
+ is a binary. Can't display content.'. This commit changes this to
+ actually include the binary file with the diff so that reviewers can
+ visually see the diff for a binary.

Status:: Discarded

~		Currently when binary files are upload for review RB simply says 'File is a binary. Can't display content.'. This commit changes this to actually include the binary file with the diff so that reviewers can visually see the diff for a binary.
	~	Currently when binary files are upload for review RB simply says 'File
	+	is a binary. Can't display content.'. This commit changes this to
	+	actually include the binary file with the diff so that reviewers can
	+	visually see the diff for a binary.

rbtools/commands/post.py (Diff revision 1)

rbtools/commands/post.py (Diff revision 2)