Add hiding min files by default

Review Request #10715 — Created Sept. 15, 2019 and updated — Latest diff uploaded

Information

Review Board
master

Reviewers

When adding minified files for review the entire file is displayed in
the diff veiwer. Since min files are just one long line this does not
make sense to display as they are generally ignored in the review
process. With this change files matching the search .min. are hidden
by default with the option to display them if the reviewer clicks
"Show content". This is similar to how deleted files are handled in the
diff viewer. Since deleted and hidden files are very similar in
functionality I merged the fields into one hidden field with an
optional hidden_context if there is need to know the reason for a file
being hidden.

Included tests for these changes.

Changes between revision 3 and 4

orig
1
2
3
4
5
6
7

Commits

Summary ID Author
test
ee4bd9ec433332bd92d603564049e92b1454ede1 Ceegan Hale
Address Barret's comments.
797cf58196b195f8eac6c5c696fb477c90665566 Ceegan Hale
Remove test file
49a4e7bc316301cc43d8e4e0d9e69bec144a6630 Ceegan Hale
reviewboard/test.min.txt
Loading...