Add hiding min files by default
Review Request #10715 — Created Sept. 15, 2019 and updated — Latest diff uploaded
When adding minified files for review the entire file is displayed in
the diff veiwer. Since min files are just one long line this does not
make sense to display as they are generally ignored in the review
process. With this change files matching the search .min. are hidden
by default with the option to display them if the reviewer clicks
"Show content". This is similar to how deleted files are handled in the
diff viewer. Since deleted and hidden files are very similar in
functionality I merged the fields into one hidden field with an
optional hidden_context if there is need to know the reason for a file
being hidden.
Included tests for these changes.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 7. See what's changed.
Commits
Files
| reviewboard/diffviewer/diffutils.py |
|---|
| reviewboard/diffviewer/views.py |
|---|
| reviewboard/diffviewer/tests/test_diffutils.py |
|---|
| reviewboard/reviews/views.py |
|---|
| reviewboard/static/rb/css/defs.less |
|---|
| reviewboard/static/rb/css/pages/diffviewer.less |
|---|
| reviewboard/static/rb/js/diffviewer/models/diffFileModel.es6.js |
|---|
| reviewboard/static/rb/js/diffviewer/models/tests/diffFileModelTests.es6.js |
|---|
| reviewboard/static/rb/js/diffviewer/views/diffFileIndexView.es6.js |
|---|
| reviewboard/templates/diffviewer/diff_file_fragment.html |
|---|