• 
      

    Fix clicking on bare rows in datagrids.

    Review Request #10712 — Created Sept. 11, 2019 and submitted

    Information

    Djblets
    release-1.0.x
    028236e...

    Reviewers

    The datagrids once had a facility for the entire row to act as a link to
    the given object. Over time as we made changes, this functionality had
    been about halfway erased, making it so only cells with .has-link
    worked as links despite the entire row having a pointer icon. This
    change fixes up things so that the URL is set correctly on the tr
    element's data, and recreates a javascript handler for clicks that are
    otherwise unhandled.

    Clicked on various cells within different dashboards and checked to
    ensure that the correct page was loaded. For cells that contained their
    own link (for example, users), saw that the row-level link was ignored
    in favor of the cell-level link. Verified that clicks on
    interaction-type cells (stars, checkboxes) did not activate the link.

    Description From Last Updated

    This can just be url.

    chipx86chipx86
    chipx86
    1. 
        
    2. djblets/static/djblets/js/datagrid.js (Diff revision 1)
       
       
      Show all issues

      This can just be url.

    3. 
        
    david
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.0.x (164b7f1)