Summary

fix broken default avatar when avatar service is file upload

Review Request #10692 — Created Sept. 6, 2019 and updated Sept. 6, 2019, 4 p.m.

Information

Owner

cathyzhang

Repository

Review Board

Branch

release-3.0.x

Bugs

4812

Depends On

~~10690~~

Reviewers

Groups

reviewboard, students

People

Description

fix broken default avatar for users when avatar service in admin is chosen as file upload

Testing Done

After selecting file upload as avatar service, all default avatars in user page works well

Commits

Summary	ID	Author
fix broken default avatar	13d298d1f4fa0abe4a43afc81a2afa8ac899100b	cathyQinQin

Issues

Description	From	Last Updated
The same comments about the change description I made on your other review request apply to this change.	chipx86	Sept. 6, 2019, 4 p.m.
This will need unit tests that prove the fixes. Tests should reproduce the original problem, fail without your fix, and …	chipx86	Sept. 6, 2019, 4 p.m.
I mentioned this in the other review request, but avatars don't always return URLs. The main point of call is …	chipx86	Sept. 6, 2019, 4 p.m.

flake8 passed.

JSHint passed.

Depends On:: ~~10690 - fix broken default avatar when avatar service is file upload~~

Bugs:: 4812

Fix it!

An issue was opened. Show all issues

The same comments about the change description I made on your other review request apply to this change.

An issue was opened. Show all issues

This will need unit tests that prove the fixes. Tests should reproduce the original problem, fail without your fix, and succeed with your fix.

An issue was opened. Show all issues

I mentioned this in the other review request, but avatars don't always return URLs. The main point of call is render(), which should also return None if it has nothing to render. We need to make sure that that path behaves correctly.
So, basically, AvatarService.render() in Djblets should return None if the URLs are None, and the code that calls for_user() and then render() should call the get_services_for_user() that I mentioned in the other review request and call render() on each until it gets a result.