Fix prepare-dev.py hook installation on Python 3
Review Request #10680 — Created Sept. 5, 2019 and submitted — Latest diff uploaded
There were two issues in the implementation of
install_git_hooksthat
prevented it from working on Python 3:
- an old-style (0777) octal literal was used instead of a new-style one
(0o777): old-style literals are not supported on Python 3; and
- bytes and unicode were being mixed inos.path.join, which is not an
issue in Python 2 but is on Python 3.Since
prepare-dev.pyis intended to install dependencies, we can't
assume the presence ofsix, so we determine the correct string type
manually.
Ran prepare-dev.py under Python 2 and Python 3 and it created git
hooks successfully.
| reviewboard/cmdline/rbsite.py |
|---|