Fix prepare-dev.py hook installation on Python 3
Review Request #10680 — Created Sept. 5, 2019 and submitted — Latest diff uploaded
There were two issues in the implementation of
install_git_hooks
that
prevented it from working on Python 3:
- an old-style (0777) octal literal was used instead of a new-style one
(0o777): old-style literals are not supported on Python 3; and
- bytes and unicode were being mixed inos.path.join
, which is not an
issue in Python 2 but is on Python 3.Since
prepare-dev.py
is intended to install dependencies, we can't
assume the presence ofsix
, so we determine the correct string type
manually.
Ran prepare-dev.py under Python 2 and Python 3 and it created git
hooks successfully.
Diff Revision 4
This is not the most recent revision of the diff. The latest diff is revision 7. See what's changed.
reviewboard/static/rb/css/pages/admin/security-center.less |
---|
reviewboard/static/rb/css/pages/admin/webhooks.less |
---|
reviewboard/static/rb/css/pages/admin/widgets.less |
---|
reviewboard/static/rb/css/ui/boxes.less |
---|
reviewboard/static/rb/css/ui/colors.less |
---|
reviewboard/static/rb/css/ui/datagrids.less |
---|
reviewboard/static/rb/css/ui/responsive.less |
---|
reviewboard/static/rb/css/ui/sidebars.less |
---|
reviewboard/static/rb/js/newReviewRequest/views/newReviewRequestView.es6.js |
---|
reviewboard/static/rb/js/views/headerView.es6.js |
---|
reviewboard/templates/base.html |
---|
reviewboard/templates/admin/base_site.html |
---|
reviewboard/templates/admin/login.html |
---|
reviewboard/templates/datagrids/datagrid.html |
---|
reviewboard/templates/reviews/reviewable_base.html |
---|
reviewboard/templates/reviews/ui/base.html |
---|