Summary

Load djblets-widgets on all pages, not just admin.

Review Request #10650 — Created July 29, 2019 and submitted July 31, 2019, 12:52 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We moved the related object selector implementation into djblets, and as
part of that change the new djblets-widgets bundle was only loaded for
admin pages. Unfortunately this broke rbintegrations features which
relied on selectize for some special fields. This change loads the
bundle on all pages, not just those in admin.

Testing Done

Was able to use rbintegrations fields based on selectize.

Commits

Summary	ID
Load djblets-widgets on all pages, not just admin. We moved the related object selector implementation into djblets, and as part of that change the new djblets-widgets bundle was only loaded for admin pages. Unfortunately this broke rbintegrations features which relied on selectize for some special fields. This change loads the bundle on all pages, not just those in admin. Testing Done: Was able to use rbintegrations fields based on selectize.	f16659a71c65a8937879774dd386145d491fc3b1

Summary

Load djblets-widgets on all pages, not just admin.

We moved the related object selector implementation into djblets, and as part of that change the new djblets-widgets bundle was only loaded for admin pages. Unfortunately this broke rbintegrations features which relied on selectize for some special fields. This change loads the bundle on all pages, not just those in admin. Testing Done: Was able to use rbintegrations fields based on selectize.

f16659a71c65a8937879774dd386145d491fc3b1

Issues

Description	From	Last Updated
The indentation is inconsistent here.	chipx86	July 30, 2019, 1:47 p.m.

flake8 passed.

JSHint passed.

reviewboard/templates/base.html (Diff revision 1)
The issue has been resolved. Show all issues
```
The indentation is inconsistent here.
```

Commits:

	Summary	ID
	Load djblets-widgets on all pages, not just admin. We moved the related object selector implementation into djblets, and as part of that change the new djblets-widgets bundle was only loaded for admin pages. Unfortunately this broke rbintegrations features which relied on selectize for some special fields. This change loads the bundle on all pages, not just those in admin. Testing Done: Was able to use rbintegrations fields based on selectize.	30c4b7999f607bbb010b3fa52e6473333cf67ce5
	Load djblets-widgets on all pages, not just admin. We moved the related object selector implementation into djblets, and as part of that change the new djblets-widgets bundle was only loaded for admin pages. Unfortunately this broke rbintegrations features which relied on selectize for some special fields. This change loads the bundle on all pages, not just those in admin. Testing Done: Was able to use rbintegrations fields based on selectize.	f16659a71c65a8937879774dd386145d491fc3b1

Diff:

Revision 2 (+4 -6)

Show changes

	reviewboard/templates/base.html
	reviewboard/templates/admin/base_site.html
	reviewboard/templates/js/tests_base.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (5690ab0)