• 
      

    Show the hosting service auth form if it has any errors.

    Review Request #10640 — Created July 19, 2019 and submitted — Latest diff uploaded

    Information

    Review Board
    release-4.0.x
    5b95312...

    Reviewers

    If editing credentials for an existing account entry for a hosting
    service, and validation fails on any of the fields, the auth form would
    be hidden, hiding the fact that anything was wrong.

    We now check whether there are any errors to show, and ensure we always
    show the form if any are found.

    Hit this while testing a change to Bitbucket. Verified that the form
    would always show up when triggering a validation failure, but was
    otherwise hidden if the fields passed validation.