• 
      

    Fix parsing of SVN diffs with binary file entries containing property changes.

    Review Request #10613 — Created July 1, 2019 and submitted

    Information

    Review Board
    release-3.0.x
    fb3c0d6...

    Reviewers

    SVN diffs can contain entries for binary files that also introduce
    property changes. We weren't handling these properly, skipping any
    parsed files that contained property changes (with the assumption being
    that they were standalone entries), but we don't want to skip them for
    binary files.

    This simply updates our logic to only skip for non-binary (standalone
    proeprty) changes.

    Unit tests pass. They failed without the fix.

    Manually tested uploading sample diffs that were missing entries due to
    the property change. Verified that all files were present and the diff was
    correct after upload.

    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (ba60b51)