• 
      

    Fix when the evolving and evolved signals are emitted.

    Review Request #10600 — Created June 18, 2019 and submitted

    Information

    Django Evolution
    master

    Reviewers

    The evolving and evolved signals were being emitted within a
    try/except, and if these had ended up raising an exception,
    evolving_failed would end up being emitted as well. This could cause
    some weirdness and broken behavior. We now emit these outside of the
    signal handler instead.

    Unit tests pass on all supported versions of Django.

    Tested upgrading a database and hitting an error in the evolved
    handler. Saw that evolving_failed did not get emitted (which caused
    a weird breakage in testing).

    Summary ID
    Fix when the evolving and evolved signals are emitted.
    The `evolving` and `evolved` signals were being emitted within a `try/except`, and if these had ended up raising an exception, `evolving_failed` would end up being emitted as well. This could cause some weirdness and broken behavior. We now emit these outside of the signal handler instead.
    a705fd4655b41d8d71e019ec66b71cbabb7ad648
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (a76938a)