Always pass an owner when spying on unbound methods.

Review Request #10596 — Created June 17, 2019 and submitted

Information

Review Board
release-4.0.x

Reviewers

Modern versions of kgb recommend passing an owner= parameter when
spying on unbound methods. This is to ensure compatibility with Python
3.x, which doesn't have a specific concept of an unbound method
(they're just standard functions). Not passing an explicit owner can
cause spies to conflict or to stay registered past the end of a test on
Python 3.x.

This change updates all our spies on unbound methods to specify an
explicit owner.

Unit tests pass.

Summary ID
Always pass an owner when spying on unbound methods.
Modern versions of kgb recommend passing an `owner=` parameter when spying on unbound methods. This is to ensure compatibility with Python 3.x, which doesn't have a specific concept of an unbound method (they're just standard functions). Not passing an explicit owner can cause spies to conflict or to stay registered past the end of a test on Python 3.x. This change updates all our spies on unbound methods to specify an explicit owner.
84ff4b4e2ce9773117501fa4482ec5bf53c0dcce
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (57045e1)