• 
      

    Bullet-proof handling of Bitbucket webhooks.

    Review Request #10584 — Created June 11, 2019 and submitted

    Information

    Review Board
    release-3.0.x

    Reviewers

    Bitbucket webhooks changed recently to sometimes exclude keys containing
    empty data, rather than just leaving them empty. This triggered parsing
    errors, since we expected them to exist.

    Our parsing is now a lot more bullet-proof. We don't assume anything is
    really there, providing defaults when parsing, and bailing if we don't
    see what we need.

    Unit tests pass.

    Summary ID
    Bullet-proof handling of Bitbucket webhooks.
    Bitbucket webhooks changed recently to sometimes exclude keys containing empty data, rather than just leaving them empty. This triggered parsing errors, since we expected them to exist. Our parsing is now a lot more bullet-proof. We don't assume anything is really there, providing defaults when parsing, and bailing if we don't see what we need.
    f37d674fc4dbb7497b4f979cf10d0e0e5218e762
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (b7fdd27)