Summary

Add and fix utility functions for working with apps and models.

Review Request #10551 — Created May 13, 2019 and submitted June 14, 2019, 2:59 a.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

Commit

6c08cdc...

Reviewers

Groups

django-evolution

People

Description

This introduces and reworks some utility functions for retrieving or

parsing information on apps. get_app_label() and get_app_name() now

retrieve their informatoin from the AppConfig on Django 1.7+, and the

AppConfig can now be retrieved through get_app_config_for_app(). The

old legacy version of the label can be returned using

get_legacy_app_label().
At the moment, this will return some incompatible information for apps

when using a new-style app label on modern versions of Django, but this

wasn't expected to work yet anyway.
Model fetching also has fixes on Django 1.7+. It no longer assumes

anything about the provided app module's label, and instead loops

through apps looking for one that owns the provided module.
These will be needed for the app label support coming in the next

change.

Testing Done

Unit tests pass on Django 1.6. This change temporarily breaks them on
newer versions.

Issues

Description	From	Last Updated
Seems like this could use your new get_app_config_for_app helper.	david	May 30, 2019, 10:51 a.m.

flake8 passed.

JSHint passed.

Change Summary:

Forgot to stage a fix for commit.

Commit:

abe0ca1476648d03bfe9356059e344d47c2baa67

6c08cdc9a834e3ee24f7474590f049aed2ffe2f8

Diff:

Revision 2 (+59 -9)

Show changes

	django_evolution/compat/models.py
	django_evolution/utils/apps.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

django_evolution/compat/models.py (Diff revision 2)

The issue has been dropped. Show all issues

Seems like this could use your new get_app_config_for_app helper.

chipx86 May 23, 2019, 2:22 a.m.

Ideally... There's currently a circular import issue, and it's something I want to figure out once I get past all the heavy lifting. In this case, the moduel that defines that method (utils/apps.py) imports compat/apps.py, which imports compat/models.py. I could have an import within the function body, but the logic is standard and safe enough where I don't want to deal with that here.
Currently, I'm saying that things in compat can't depend on utils.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (0e4e3e0)