• 
      

    Fix issue with _process_files being too strict in its type-checking.

    Review Request #10549 — Created May 9, 2019 and submitted

    Information

    Review Board
    release-4.0.x
    cd2fce6...

    Reviewers

    A recent change went in to ensure that various things were the correct
    string type, but the checking for the result of
    SCMTool.parse_diff_revision was too strict, allowing only bytes but
    not Revision objects. This would cause diff validation errors when
    attempting to post newly-added files.

    Was able to post a change including a newly-added file.

    Description From Last Updated

    Swap these.

    chipx86chipx86
    chipx86
    1. 
        
    2. reviewboard/diffviewer/filediff_creator.py (Diff revision 1)
       
       
       
      Show all issues

      Swap these.

    3. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (0618a7d)